• Hi Guest! To get rid of ads on the page, please consider donating through user upgrades or other methods.

Script for creating voice packs

Devil

Cricket
Member

Attachments

  • !copy soundpack 19092018.rar
    3.2 KB · Views: 44

cupid

Forgiving
Staff member
Moderator
Member
I know this isn't a place to post code reviews (there's https://codereview.stackexchange.com/ for that), but your script has some minor things that need to be changed.

  • This line:
    Code:
    echo off
    Is after all the junk has been output.
    That's not how it works!
    You have to have this:
    Code:
    @echo off
    Right in the top of the file.

  • This line:
    Code:
    md C:\UPKSoundPack09192018\
    Will force the person to start it as Administrator, and you don't give any warning when the user doesn't.
    Use the value %~dp0 to create a folder in the same place as the file.

  • Code:
    copy description.txt C:\UPKSoundPack09192018\
    ^ that file doesn't exist and is used by BnSBuddy only.

  • You don't check in any way, shape or form if you are in the right folder or not, which is mostly fine.
    But users are users and probably won't find the folder.
And that's it!
You can take some tips from my Xigncode Installer, if you wish to add more functionality, like, automatically generating the description.txt file and compressing it.
 

Devil

Cricket
Member
I know this isn't a place to post code reviews (there's https://codereview.stackexchange.com/ for that), but your script has some minor things that need to be changed.

  • This line:
    Code:
    echo off
    Is after all the junk has been output.
    That's not how it works!
    You have to have this:
    Code:
    @echo off
    Right in the top of the file.

  • This line:
    Code:
    md C:\UPKSoundPack09192018\
    Will force the person to start it as Administrator, and you don't give any warning when the user doesn't.
    Use the value %~dp0 to create a folder in the same place as the file.

  • Code:
    copy description.txt C:\UPKSoundPack09192018\
    ^ that file doesn't exist and is used by BnSBuddy only.

  • You don't check in any way, shape or form if you are in the right folder or not, which is mostly fine.
    But users are users and probably won't find the folder.
And that's it!
You can take some tips from my Xigncode Installer, if you wish to add more functionality, like, automatically generating the description.txt file and compressing it.

Hi, thank you for your tips !
I will take this in mind in future !
That was my first script for BnS Buddy, So I guess I have some mistakes :D

md command isn't ask for admin rights o_O
works for me but I will try to improve it next time
 

cupid

Forgiving
Staff member
Moderator
Member
Hi, thank you for your tips !
I will take this in mind in future !
That was my first script for BnS Buddy, So I guess I have some mistakes :D

md command isn't ask for admin rights o_O
works for me but I will try to improve it next time

Well, the C: drive is, usually, protected for writting.
This is because of a few files that can't be touched there.

If you need more tips, you can post your question in https://codereview.stackexchange.com/ as well.
They are very helpful there.
 
Top Bottom